Skip to content

WIP - Use Pundle as the module bundler - #268

Closed
steelbrain wants to merge 9 commits into
react:masterfrom
steelbrain:move-to-pundle
Closed

WIP - Use Pundle as the module bundler#268
steelbrain wants to merge 9 commits into
react:masterfrom
steelbrain:move-to-pundle

Conversation

@steelbrain

@steelbrain steelbrain commented Jul 28, 2016

Copy link
Copy Markdown

⚠️ This PR is in no way feature complete and is just meant to start the discussion ⚠️

Reference: #93 (comment)

This PR uses the Pundle module bundler instead of Webpack

What's working?

  • Hot reloads
  • Everything JS + JSON

What needs some work?

  • Non JS requires
  • ESLint

I will be implementing the missing plugins for Pundle as we make progress on this PR

What's the benefit?

Well documented and maintained software that has extremely fast bundling and hot reload speed compared to Webpack

cc @gaearon

Comment thread package.json Outdated
"babel-preset-es2015": "6.9.0",
"babel-preset-es2016": "6.11.3",
"babel-preset-react": "6.11.1",
"babel-pundle": "^1.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the other requirements here are fixed versions instead of ^, probably it's better to do the same for pundle

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lacker

lacker commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

Does pundle support any sort of built-in proxying behavior? We need something like that to support backend servers.

If we used pundle instead of webpack, do you think pundle should also be used to package files for the test environment? Or is that not a good fit for pundle?

Comment thread scripts/start.js Outdated
const debugInfo = debug('REACT-APP:Info')
const debugError = debug('REACT-APP:Error')

const port = 8056

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be process.env.PORT || 3000 ?

@ghost ghost added the CLA Signed label Jul 28, 2016
@lacker

lacker commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

You would want to change build.js too I presume, so that we would no longer have any webpack dependencies.

@steelbrain

Copy link
Copy Markdown
Author

Pundle supports fully configurable bundle paths (including their source map and hmr paths) so it's very easy to use it behind a proxy. In fact we're already using it in our dev environment.

Also Pundle has two main external components, The Dev Server and the main CLI, it can compile anything and probably more than what webpack is capable of :)

Also I'm working on transitioning build.js too right now, as the title says it's still a WIP but reviews are very much welcome on the stuff committed in

@TheLarkInn

Copy link
Copy Markdown

Would love to see production build sizes and benchmarks on the page speed.

@gaearon

gaearon commented Aug 2, 2016

Copy link
Copy Markdown
Contributor

This doesn’t currently handle styles, does it?

@steelbrain

steelbrain commented Aug 2, 2016

Copy link
Copy Markdown
Author

This is build time in Pundle vs Webpack (respectively)

That's like a 2.3x boost. Pundle is especially fast at HMR, it's HMRs are near-instant.

@gaearon Yeah it's being actively worked on, as the ETA it's happening soon :)
@TheLarkInn Pundle's build sizes are slightly bigger than webpack's at the moment but the runtime performance is probably faster. Sizes are gonna be fixed soon.
It's mainly because webpack has been tweaked heavily to minificiation and all

@ghost ghost added the CLA Signed label Aug 2, 2016
@gaearon

gaearon commented Sep 3, 2016

Copy link
Copy Markdown
Contributor

Closing as outdated, but feel free to reopen when there is a reasonable feature parity!

@gaearon gaearon closed this Sep 3, 2016
@ackvf

ackvf commented Nov 16, 2017

Copy link
Copy Markdown

I wonder if there is any update on this. ?

nicosommi pushed a commit to nicosommi/create-react-app that referenced this pull request Mar 17, 2018
fix(readme): use the prepacked logo.svg as an example in "Adding Imag…
@lock lock Bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants